Skip to content

Commit

Permalink
Improve error message when neon.max_cluster_size reached (#4173)
Browse files Browse the repository at this point in the history
Changes the error message encountered when the `neon.max_cluster_size`
limit is reached. Reasoning is that this is user-visible, and so should
*probably* use language that's closer to what users are familiar with.
  • Loading branch information
sharnoff committed Nov 16, 2023
1 parent 0c243fa commit 5d13a2e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pgxn/neon/pagestore_smgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -1687,9 +1687,9 @@ neon_extend(SMgrRelation reln, ForkNumber forkNum, BlockNumber blkno,
if (current_size >= ((uint64) max_cluster_size) * 1024 * 1024)
ereport(ERROR,
(errcode(ERRCODE_DISK_FULL),
errmsg("could not extend file because cluster size limit (%d MB) has been exceeded",
errmsg("could not extend file because project size limit (%d MB) has been exceeded",
max_cluster_size),
errhint("This limit is defined by neon.max_cluster_size GUC")));
errhint("This limit is defined externally by the project size limit, and internally by neon.max_cluster_size GUC")));
}

/*
Expand Down

1 comment on commit 5d13a2e

@github-actions
Copy link

@github-actions github-actions bot commented on 5d13a2e Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2456 tests run: 2333 passed, 0 failed, 123 skipped (full report)


Flaky tests (4)

Postgres 16

Postgres 15

  • test_pageserver_chaos: debug

Postgres 14

  • test_pageserver_restart[False]: debug
  • test_empty_tenant_size: debug

Code coverage (full report)

  • functions: 54.9% (9090 of 16571 functions)
  • lines: 81.6% (52327 of 64149 lines)

The comment gets automatically updated with the latest test results
5d13a2e at 2023-11-17T00:34:03.740Z :recycle:

Please sign in to comment.