Skip to content

Commit

Permalink
fix clippy
Browse files Browse the repository at this point in the history
Signed-off-by: Alex Chi Z <chi@neon.tech>
  • Loading branch information
skyzh committed Jun 24, 2024
1 parent c9e56b5 commit 504c9a6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion pageserver/src/http/routes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1706,7 +1706,6 @@ async fn timeline_compact_handler(
if !cfg!(feature = "testing") {
return Err(ApiError::InternalServerError(
anyhow!("enhanced_gc_bottom_most_compaction is only available in testing mode")
.into(),
));
}
flags |= CompactFlags::EnhancedGcBottomMostCompaction;
Expand Down
3 changes: 1 addition & 2 deletions pageserver/src/tenant/timeline/compaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -981,8 +981,7 @@ impl Timeline {
let guard = self.layers.read().await;
let layers = guard.layer_map();
let gc_info = self.gc_info.read().unwrap();
if !gc_info.retain_lsns.is_empty() {
// TODO: add lease LSNs
if !gc_info.retain_lsns.is_empty() || !gc_info.leases.is_empty() {
return Err(CompactionError::Other(anyhow!(
"enhanced legacy compaction currently does not support retain_lsns (branches)"
)));
Expand Down

0 comments on commit 504c9a6

Please sign in to comment.