-
Notifications
You must be signed in to change notification settings - Fork 409
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(pageserver): ensure to_i128 works for metadata keys (#7895)
field2 of metadata keys can be 0xFFFF because of the mapping. Allow 0xFFFF for `to_i128`. An alternative is to encode 0xFFFF as 0xFFFFFFFF (which is allowed in the original `to_i128`). But checking the places where field2 is referenced, the rest part of the system does not seem to depend on this assertion. Signed-off-by: Alex Chi Z <chi@neon.tech>
- Loading branch information
Showing
1 changed file
with
12 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1eca8b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3238 tests run: 3092 passed, 0 failed, 146 skipped (full report)
Flaky tests (2)
Postgres 16
test_vm_bit_clear_on_heap_lock
: debugPostgres 15
test_pageserver_restarts_under_worload
: releaseCode coverage* (full report)
functions
:31.4% (6491 of 20671 functions)
lines
:48.4% (50195 of 103746 lines)
* collected from Rust tests only
1eca8b8 at 2024-05-30T15:38:36.998Z :recycle: