Skip to content

Commit

Permalink
Increase timeout for wating subscriber caught-up (#8118)
Browse files Browse the repository at this point in the history
## Problem

test_subscriber_restart has quit large failure rate'

https://neonprod.grafana.net/d/fddp4rvg7k2dcf/regression-test-failures?orgId=1&var-test_name=test_subscriber_restart&var-max_count=100&var-restrict=false

I can be caused by too small timeout (5 seconds) to wait until changes
are propagated.

Related to #8097

## Summary of changes

Increase timeout to 30 seconds.

## Checklist before requesting a review

- [ ] I have performed a self-review of my code.
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Do we need to implement analytics? if so did you add the relevant
metrics to the dashboard?
- [ ] If this PR requires public announcement, mark it with
/release-notes label and add several sentences in this section.

## Checklist before merging

- [ ] Do not forget to reformat commit message to not include the above
checklist

Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
  • Loading branch information
knizhnik and Konstantin Knizhnik committed Jul 5, 2024
1 parent c9fd8d7 commit 13522fb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test_runner/regress/test_subscriber_restart.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ def insert_data(pub):
pcur.execute(f"INSERT into t values ({n_records}, 0)")
n_records += 1
with sub.cursor() as scur:
wait_until(10, 0.5, check_that_changes_propagated)
wait_until(60, 0.5, check_that_changes_propagated)

1 comment on commit 13522fb

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3129 tests run: 3002 passed, 0 failed, 127 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_lsn_lease_size[False]: debug

Code coverage* (full report)

  • functions: 32.6% (6932 of 21275 functions)
  • lines: 50.0% (54496 of 108968 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
13522fb at 2024-07-05T19:06:14.277Z :recycle:

Please sign in to comment.