Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(neon): JsFunction::bind() and Object::prop() #1056

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat(neon): JsFunction::bind() and Object::prop() #1056

wants to merge 22 commits into from

Commits on Sep 8, 2024

  1. Implement JsFunction::bind(), which creates a builder for calling a f… 

    …unction using the Try{From,Into}Js traits.
    @dherman
    dherman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    cc1b061 View commit details
    Browse the repository at this point in the history

  2. prettier

    @dherman
    dherman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    f7c05b8 View commit details
    Browse the repository at this point in the history

  3. cargo fmt --all

    @dherman
    dherman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    8c03fab View commit details
    Browse the repository at this point in the history

  4. Add PropOptions and Object::prop() for accessing object properties … 

    …expressively
    @dherman
    dherman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    33b0c2a View commit details
    Browse the repository at this point in the history

  5. api doc formatting

    @dherman
    dherman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    acf0ec5 View commit details
    Browse the repository at this point in the history

  6. tweak test name for clarity

    @dherman
    dherman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    3d32a52 View commit details
    Browse the repository at this point in the history

  7. Optimization: only do the function type check of the callee when call… 

    …ing BindOptions::apply()
    @dherman
    dherman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    db27665 View commit details
    Browse the repository at this point in the history

  8. rebase: {Bind,Prop}Options take Cx instead of generic C: Context

    @dherman
    dherman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    a3f084d View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. remove unnecessary sys::fun::call helper, and add test case for calli… 

    …ng non-functions with .bind()
    @dherman
    dherman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    589fabc View commit details
    Browse the repository at this point in the history

  2. prettier

    @dherman
    dherman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    59fa3f4 View commit details
    Browse the repository at this point in the history

  3. cargo fmt --all

    @dherman
    dherman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c4fcf56 View commit details
    Browse the repository at this point in the history

  4. style: move long type parameter list to where-clause

    @dherman
    dherman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7ef24b5 View commit details
    Browse the repository at this point in the history

  5. more style nits (where-clauses)

    @dherman
    dherman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d2c770d View commit details
    Browse the repository at this point in the history

  6. arg_with's closure doesn't need to require a Result, since TryIntoJs … 

    …is already implemented for NeonResult
    @dherman
    dherman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8d18e19 View commit details
    Browse the repository at this point in the history

  7. remove unnecessary unsafe: use .as_value() instead

    @dherman
    dherman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b2a34c0 View commit details
    Browse the repository at this point in the history

  8. BindOptions::this() takes a TryIntoJs (and is therefore fallible) 

    - tests for both strict and sloppy mode functions to show it works on primitives
    @dherman
    dherman committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    94a0c08 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. store object in PropOptions as a JsObject so it doesn't need a ty… 

    …pe parameter other than for the key
    @dherman
    dherman committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    45be1f3 View commit details
    Browse the repository at this point in the history

  2. avoid the double-type-check of eagerly downcasting to function when c… 

    …alling .bind(), since it's performed when calling .apply()
    @dherman
    dherman committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bb4f231 View commit details
    Browse the repository at this point in the history

  3. style: move the InvalidArg tag check to a match guard 

    Co-authored-by: K.J. Valencik <kjvalencik@gmail.com>
    @dherman @kjvalencik
    dherman and kjvalencik committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    dd1ffdf View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. argc can be usize now that we're not using the c++ backend

    @dherman
    dherman committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3257f01 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. BindOptions::args_with() and equivalent BindOptions::args(With(...))

    @dherman
    dherman committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6148d8e View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. more readable logic for impl_arguments! and impl_into_arguments! macros

    @dherman
    dherman committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    50a8832 View commit details
    Browse the repository at this point in the history