Accepting nil as enum value
#1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 97.26% (diff: 100%)@@ 7.0.x #1270 diff @@
==========================================
Files 168 168
Lines 10404 10418 +14
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 10119 10133 +14
Misses 285 285
Partials 0 0
|
| @@ -29,7 +29,7 @@ A Neo4j OGM (Object-Graph-Mapper) for use in Ruby on Rails and Rack frameworks h | |||
| s.add_dependency('orm_adapter', '~> 0.5.0') | |||
| s.add_dependency('activemodel', '~> 4') | |||
| s.add_dependency('activesupport', '~> 4') | |||
| s.add_dependency('neo4j-core', '>= 6.0.0') | |||
There was a problem hiding this comment.
Maybe both >= 6.0.0 and < 7.0.0? Is that possible in a gemspec?
There was a problem hiding this comment.
@cheerfulstoic Yup, it's possible ;)
|
I'm good with this! I hope that nobody is depending on the breaking change, but they may very well need the |
|
Great! Dunno if it's ok to merge now, or just wait for the test here: #1261 |
|
@cheerfulstoic ruby 2.0.0 fails to bundle ._. |
|
Fixed! |
cheerfulstoic
added a commit
that referenced
this pull request
Aug 18, 2016
ProGM
added a commit
that referenced
this pull request
Aug 21, 2016
* 7.1.x: Release .15 patch with #1270 change Trying to fix ruby 2.0 build. Fix gemspec. Fix Gemfile for jruby. Accepting `nil` as enum value Update ActiveRel.rst Up to 7.1.2 to include fix from model_label_map_fix Put this back, because of course it broke things Fix issue with label / model mappings getting stuck before all models have a chance to load. Also don't clear WRAPPED_CLASSES (I think this will fix the CypherNode issue we've been seeing in development
ProGM
added a commit
that referenced
this pull request
Aug 21, 2016
* 8.0.x: CHANGELOG entry for #1254 Improvements based on #1264 Destroy should return object like in ActiveRecord Use ActiveSupport::Logger instead of base Logger Release .15 patch with #1270 change Trying to fix ruby 2.0 build. Fix gemspec. Fix Gemfile for jruby. Accepting `nil` as enum value Add information about which exceptions are replacing old exceptions Update ActiveRel.rst Up to 7.1.2 to include fix from model_label_map_fix Put this back, because of course it broke things Fix issue with label / model mappings getting stuck before all models have a chance to load. Also don't clear WRAPPED_CLASSES (I think this will fix the CypherNode issue we've been seeing in development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1261
This pull introduces/changes:
:_defaultoption to define the default value for enums.This is a braking change.
If we want to keep the previous behavior, we can implement an
_allow_niloption, to enablenilas default value.Pings:
@cheerfulstoic
@subvertallchris