Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

destroy should return the object #1254

Closed
cheerfulstoic opened this issue Aug 4, 2016 · 4 comments
Closed

destroy should return the object #1254

cheerfulstoic opened this issue Aug 4, 2016 · 4 comments
Milestone
8.0.0

Comments

@cheerfulstoic
Copy link
Contributor

This is consistent with what ActiveRecord does. Currently ActiveNode models return true when destroy is called.

Should be easy, and 8.0 would be a good time for the API change
@cheerfulstoic cheerfulstoic added this to the 8.0.0 milestone Aug 4, 2016
@subvertallchris
Copy link
Contributor

I personally prefer our approach but do agree that we should maintain
parity with AR to prevent surprise. That's definitely one to display
prominently in the changelog!

On Thursday, August 4, 2016, Brian Underwood notifications@github.com
wrote:

This is consistent with what ActiveRecord does. Currently ActiveNode
models return true when destroy is called.

Should be easy, and 8.0 would be a good time for the API change

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1254, or mute the thread
https://github.com/notifications/unsubscribe-auth/AD6E9wdampCBcEbc5O0VfrNrPCwES_N5ks5qcdfpgaJpZM4JcopA
.

@cheerfulstoic
Copy link
Contributor Author

Definitely in the CHANGELOG as well as the migration guide

cheerfulstoic added a commit that referenced this issue Aug 21, 2016
@cheerfulstoic
CHANGELOG entry for #1254
9d5d93e
@cheerfulstoic
Copy link
Contributor Author

Done on 8.0.x

ProGM added a commit that referenced this issue Aug 21, 2016
@ProGM
Merge branch '8.0.x'
998984a 
* 8.0.x:
  CHANGELOG entry for #1254
  Improvements based on #1264
  Destroy should return object like in ActiveRecord
  Use ActiveSupport::Logger instead of base Logger
  Release .15 patch with #1270 change
  Trying to fix ruby 2.0 build.
  Fix gemspec.
  Fix Gemfile for jruby.
  Accepting `nil` as enum value
  Add information about which exceptions are replacing old exceptions
  Update ActiveRel.rst
  Up to 7.1.2 to include fix from model_label_map_fix
  Put this back, because of course it broke things
  Fix issue with label / model mappings getting stuck before all models have a chance to load.  Also don't clear WRAPPED_CLASSES (I think this will fix the CypherNode issue we've been seeing in development
@ProGM
Copy link
Member

ProGM commented Sep 16, 2016

Closing since it's released in 8.0.0.alpha.4

@ProGM ProGM closed this as completed Sep 16, 2016
@ProGM ProGM removed the in master label Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@cheerfulstoic @subvertallchris @ProGM