Add GitHub actions file #49
Conversation
.github/workflows/workflow.yml
Outdated
| test-server: | ||
| runs-on: ubuntu-latest | ||
| needs: [download-vectors] | ||
| container: docker/compose |
There was a problem hiding this comment.
Remove the container line from each job. For jobs requiring Docker Compose, nothing is required since it's built-in to GitHub Actions. For others such as Node.js, use something like the Node.js GitHub Actions to pull in the latest LTS.
There was a problem hiding this comment.
I am not sure how to use node actions, please review the updated file
| - run: sh scripts/deploy.sh | ||
| timeout-minutes: 120 | ||
|
|
||
| pages: |
There was a problem hiding this comment.
Use the crazy-max/ghaction-github-pages@v2 GitHub Action to host the docs instead of uploading the artifact.
|
I'm confused as to what the difference between #49 and #52 is. Is @geekypandey trying to merge his PR into this branch instead? |
|
Sorry for the confusion. I made changes to #49, to make it work. @garg-saurav asked for some help for the same. My bad, I should have mentioned it in the issue. |
|
Your changes are for #49 but they're on a separate branch, repo, and PR. You should PR into his branch/repo instead of the |
|
okay! |
Issue #48