Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web ui stream fixes #21

Merged
merged 3 commits into from
Dec 12, 2018
Merged

Conversation

frecuencialibre
Copy link
Collaborator

This pr gets us part of the way to fixing #16 out of the box:

  • ensure the instance can find itself at EXTERNAL_HOSTNAME. this avoids the error message in the stream settings you can see in the screenshot in the issue above.
  • set the EXTERNAL_HOSTNAME as the default instead of localhost

at this point i think that providing an out-of-the box solution to #16 would require resolving #20. alternatively we could just add instructions for the Settings > Streams post-install step to the readme.

@frecuencialibre
Copy link
Collaborator Author

this PR would also close #11

Copy link
Owner

@ned-kelly ned-kelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, however we need to test that the "generalHost" (in the setup wizard) still works ok.

fe9faa8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants