feat: add global labes for node metrics

necordjs · Dec 29, 2023 · fe192c3 · fe192c3
1 parent f4919d1
commit fe192c3
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 19 deletions.
diff --git a/src/app.module.ts b/src/app.module.ts
@@ -1,4 +1,4 @@
-import { Module, OnModuleInit } from '@nestjs/common';
+import { Module } from '@nestjs/common';
 import { NecordModule } from 'necord';
 import { ConfigModule, ConfigService } from '@nestjs/config';
 import { DocsModule } from './docs/docs.module';
@@ -7,8 +7,6 @@ import { GeneralModule } from './general/general.module';
 import { AppService } from './app.service';
 import { TagsModule } from './tags/tags.module';
 import { ChangelogModule } from './changelog/changelog.module';
-import { metrics } from '@opentelemetry/api';
-import { setupNodeMetrics } from '@sesamecare-oss/opentelemetry-node-metrics';
 
 @Module({
 	imports: [
@@ -35,10 +33,4 @@ import { setupNodeMetrics } from '@sesamecare-oss/opentelemetry-node-metrics';
 	],
 	providers: [AppService]
 })
-export class AppModule implements OnModuleInit {
-	public onModuleInit(): any {
-		const meterProvider = metrics.getMeterProvider();
-		const meter = meterProvider.getMeter('node-metrics');
-		setupNodeMetrics(meter);
-	}
-}
+export class AppModule {}
diff --git a/src/main.ts b/src/main.ts
@@ -1,4 +1,4 @@
-import otelSDK from './tracing';
+import { otelSDK } from './tracing';
 import { NestFactory } from '@nestjs/core';
 import { AppModule } from './app.module';
 

diff --git a/src/tracing.ts b/src/tracing.ts
@@ -7,25 +7,35 @@ import {
 import { Logger } from '@nestjs/common';
 import { Resource } from '@opentelemetry/resources';
 import { SemanticResourceAttributes } from '@opentelemetry/semantic-conventions';
+import { metrics } from '@opentelemetry/api';
+import { setupNodeMetrics } from '@sesamecare-oss/opentelemetry-node-metrics';
 
 const logger = new Logger('OpenTelemetry');
 
 const metricReader = new PrometheusExporter({ port: 8081 }, () =>
 	logger.log('Prometheus scrape endpoint started on port 8081')
 );
 
-const otelSDK = new NodeSDK({
-	resource: new Resource({
-		[SemanticResourceAttributes.SERVICE_NAME]: 'toolkit',
-		[SemanticResourceAttributes.SERVICE_NAMESPACE]: 'necord',
-		[SemanticResourceAttributes.SERVICE_VERSION]: '1.0.0'
-	}),
+const resource = new Resource({
+	[SemanticResourceAttributes.SERVICE_NAME]: 'toolkit',
+	[SemanticResourceAttributes.SERVICE_NAMESPACE]: 'necord',
+	[SemanticResourceAttributes.SERVICE_VERSION]: '1.0.0'
+});
+
+const instrumentations = [getNodeAutoInstrumentations()];
+
+export const otelSDK = new NodeSDK({
+	resource,
 	metricReader,
-	instrumentations: [getNodeAutoInstrumentations()],
+	instrumentations,
 	resourceDetectors: getResourceDetectors()
 });
 
-export default otelSDK;
+setImmediate(() => {
+	const meterProvider = metrics.getMeterProvider();
+	const meter = meterProvider.getMeter('node-metrics');
+	setupNodeMetrics(meter, { labels: resource.attributes as any });
+});
 
 // You can also use the shutdown method to gracefully shut down the SDK before process shutdown
 // or on some operating system signal.