Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConversationalBufferWindowMemory => ConversationBufferWindowMemory #212

Merged
merged 2 commits into from
Mar 8, 2023
Merged

ConversationalBufferWindowMemory => ConversationBufferWindowMemory #212

merged 2 commits into from
Mar 8, 2023

Conversation

bzantium
Copy link

@bzantium bzantium commented Mar 8, 2023 

from langchain.chains.conversation.memory import (
    ConversationalBufferWindowMemory,
)

=>

from langchain.chains.conversation.memory import (
    ConversationBufferWindowMemory,
)

@diegofiori
Copy link
Collaborator

Hi @bzantium, thank you a lot for the contribution. We moved the generate_dataset.py in the artifacts folder and renamed it to generate_actor_dataset.py. Could you please update your branch and modify directly the generate_actor_dataset.py?

@diegofiori
Copy link
Collaborator

@bzantium I directly solved the merge issues on my side. Thanks again for contributing

@diegofiori diegofiori merged commit e0ba15e into nebuly-ai:main Mar 8, 2023
@diegofiori diegofiori mentioned this pull request Mar 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzantium @diegofiori