Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move codespell config to pyproject.toml only #2611

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Aug 6, 2024

Reference Issues or PRs

The codespell config was added to pyproject.toml in #2583. This allows users to run codespell from command line and pick up the config as well as be picked up by pre-commit. Typos config is already in pyproject as well since some options couldn't be set via command line.
I think we should move the codespell config there exclusively so we don't have to update things in 2 places. The only difference is we still want --write on pre-commit, but not when using codespell from command line.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): cicid

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Adam-D-Lewis Adam-D-Lewis merged commit a65ff53 into develop Aug 6, 2024
4 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the move_codespell_config_to_pyproject branch August 6, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants