-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to node test runner #1129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The switch to node test runner looks fine, just a couple of small comments.
Regarding the bug with node 20, is this a known issue? Is there an existing bug issue to track it?
haven't found one, the one in references is one of the few duplicates about the same error. The workaround of using a newer node version seems to be working based on the following action https://github.com/nearform/the-fastify-workshop/actions/runs/7736673623/job/21094398580 The original action in the repository seems to go on and on and so the workaround works but I do not have any idea about the root cause |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job
Refactors the following to use node test runner instead of Tap
Note
The timeout issue still exists, as it's a problem with node v20 itself and not tap / node test runner.
Workaround for the infinite loop and getting stuck is to use Node 21, which doesn't sit well with the
lts/*
rule we have.References
closes: #1128