Fix: Add --dry-run to the tool for applying state-parts #8739
Conversation
|
I think @marcelo-gonzalez might be a good reviewer for this PR. As they are not a codeowner, I am happy to approve once they do the review. |
|
|
||
| /// Selects an epoch. The dump will be of the state at the beginning of this epoch. | ||
| #[clap(subcommand)] | ||
| epoch_selection: EpochSelection, |
There was a problem hiding this comment.
epoch_selection appears in both subcommands. Should it go to the parent command? Not saying it necessarily should just because of that (you might have plans to add another command that doesnt want that flag). But maybe makes sense if it should be common to any state parts related cmd
There was a problem hiding this comment.
Would be nice, but clap doesn't allow more than 1 subcommand per command.
Have to go with a common sub-sub-command.
There was a problem hiding this comment.
ah no i meant like as one of the options in struct StatePartsCmd. not a huge deal though obviously
Also rework the state parts command API to be a single command with two subcommands instead of two separate commands.