Added peer store information to network page #7761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina86
approved these changes
Oct 4, 2022
matklad
reviewed
Oct 4, 2022
| }) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| peer_states_view.sort_by(|a, b| { |
chain/network/Cargo.toml
Outdated
| @@ -50,6 +50,7 @@ time.workspace = true | |||
| delay-detector = { path = "../../tools/delay-detector" } | |||
| near-o11y = { path = "../../core/o11y" } | |||
| near-crypto = { path = "../../core/crypto" } | |||
| near-client-primitives = {path = "../client-primitives"} | |||
There was a problem hiding this comment.
Can we avoid this deps? This adds chain&client stuff to the transitive closure of network deps
There was a problem hiding this comment.
+1, you can add a new public type to near-network, and then translate it to an isomorphic type in client, like here:
nearcore/chain/client/src/client_actor.rs
Line 779 in 017b433
pompon0
reviewed
Oct 5, 2022
| @@ -1722,3 +1727,34 @@ impl Handler<PeerManagerMessageRequest> for PeerManagerActor { | |||
| self.handle_peer_manager_message(msg, ctx) | |||
| } | |||
| } | |||
|
|
|||
| impl Handler<NetworkDebugStatus> for PeerManagerActor { | |||
There was a problem hiding this comment.
Once you remove the dependency on client_primitives, rename "NetworkDebugStatus, DebugStatusResponse" to
"GetDebugStatus, DebugStatus":
- "Network" is implied by the package name
- the request name should be either a verb, or end with "Request"
- "Response" suffix is redundant as long as the response type can be interpreted on its own (i.e. without the request).
pompon0
reviewed
Oct 5, 2022
| @@ -1722,3 +1727,34 @@ impl Handler<PeerManagerMessageRequest> for PeerManagerActor { | |||
| self.handle_peer_manager_message(msg, ctx) | |||
| } | |||
| } | |||
|
|
|||
| impl Handler<NetworkDebugStatus> for PeerManagerActor { | |||
| type Result = Result<DebugStatusResponse, StatusError>; | |||
There was a problem hiding this comment.
It seems to me that "type Result = DebugStatusResponse" would be enough here, since this call never returns an error.
nikurt
pushed a commit
that referenced
this pull request
Oct 25, 2022
Display a list of peers stored in peer store - together with information on when we attempted to connect to them. You can see it working in: http://34.147.53.32:3030/debug/pages/network_info This is at the bottom of the page - and you have to click the button to fetch this info (as this is often over 10k peers - and loading takes a while).
nikurt
pushed a commit
that referenced
this pull request
Nov 7, 2022
Display a list of peers stored in peer store - together with information on when we attempted to connect to them. You can see it working in: http://34.147.53.32:3030/debug/pages/network_info This is at the bottom of the page - and you have to click the button to fetch this info (as this is often over 10k peers - and loading takes a while).
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Display a list of peers stored in peer store - together with information on when we attempted to connect to them. You can see it working in: http://34.147.53.32:3030/debug/pages/network_info This is at the bottom of the page - and you have to click the button to fetch this info (as this is often over 10k peers - and loading takes a while).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display a list of peers stored in peer store - together with information on when we attempted to connect to them.
You can see it working in: http://34.147.53.32:3030/debug/pages/network_info
This is at the bottom of the page - and you have to click the button to fetch this info (as this is often over 10k peers - and loading takes a while).