network: deprecate near_peer_message_received_total #7548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate near_peer_message_received_total Prometheus metric in favour of aggregating near_peer_message_received_by_type_total metric instead.
mm-near
reviewed
Sep 5, 2022
| @@ -102,10 +102,11 @@ pub(crate) static PEER_MESSAGE_RECEIVED_BY_TYPE_BYTES: Lazy<IntCounterVec> = Laz | |||
| ) | |||
| .unwrap() | |||
| }); | |||
| // TODO(mina86): This has been deprecated in 1.30. Remove at 1.32 or so. | |||
There was a problem hiding this comment.
+1 for leaving such comments !
mm-near
approved these changes
Sep 5, 2022
|
I am a bit surprised that we go with deprecation here. I guess some validators may setup alerts on the metrics, so metrics are part of our public API, and so we can't just remove them? |
|
We’re not just removing the metric. It’s deprecated so users have time to migrate and this will be mentioned in release notes which validators should / do read. |
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Deprecate near_peer_message_received_total Prometheus metric in favour of aggregating near_peer_message_received_by_type_total metric instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate near_peer_message_received_total Prometheus metric in favour
of aggregating near_peer_message_received_by_type_total metric instead.