nearcore: deprecate network configurations’s external_address field #7300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field has never been used. It’s only causes confusion as to its purpose. Deprecate it. Issue: near#7198
pompon0
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
nit: you might want to make it more uniform and generalize this a bit: have a constant set containing list of deprecated fields (annotated with scheduled deletion time) then extract these fields after serde_ignored::deserialize (to decrease the level of nesting, for readability).
matklad
approved these changes
Aug 1, 2022
|
There is in fact #6436 which calls for generalisation of this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field has never been used. It’s only causes confusion as to its
purpose. Deprecate it.
Issue: #7198