[1.39] runtime: add metrics for receipt throughput #10944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also time it takes to process them.
nagisa
changed the title
bowenwang1996
approved these changes
Apr 4, 2024
wacban
reviewed
Apr 4, 2024
| } | ||
|
|
||
| /// Report statistics | ||
| pub fn report(&self, shard_id: &str) { | ||
| pub fn report(&mut self, shard_id: &str) { |
There was a problem hiding this comment.
Where possible please use ShardUID to make it future proof (most notably for resharding as multiple shards with same ids exist at the same time). Not a blocker though.
There was a problem hiding this comment.
In the context of metrics, it is better to have this consistent notation for aggregation purpose. We can work on a migration plan to add ShardUID to all metrics.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
And also time it takes to process them. This is a forward-port of #10944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also time it takes to process them.
I kinda didn't really think about how to do this right and more about how to do it fast. My head is also not working anymore today so unless its minor typo fixes, its probably better if somebody else addresses it...