Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integration tests for meta transactions #8467

Closed
13 tasks done
Tracked by #8075
jakmeier opened this issue Jan 31, 2023 · 3 comments
Closed
13 tasks done
Tracked by #8075

add integration tests for meta transactions #8467

jakmeier opened this issue Jan 31, 2023 · 3 comments
Assignees
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) T-contract-runtime Team: issues relevant to the contract runtime team

Comments

@jakmeier
Copy link
Contributor

jakmeier commented Jan 31, 2023

Goal: Assure full test coverage of meta transactions.

We already have unit test that trigger all of the potential errors, except for the error about nested delegate actions.

Additionally, I propose to add tests on the trait User abstraction level, basically end-to-end as far as nearcore is concerned. There, I would like to see one test for each type of action. And a couple of common scenarios.

@jakmeier jakmeier added A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) T-contract-runtime Team: issues relevant to the contract runtime team labels Jan 31, 2023
@jakmeier jakmeier self-assigned this Jan 31, 2023
@jakmeier
Copy link
Contributor Author

I think now that #8538 has removed the nested delegate error, we don't really need a test for it.

We could only add a test for deserialization to fail. That seems to be an overkill for integration tests. We already have unit tests in core/primitives/src/delegate_action.rs that check (de-)serialization works as intended.

=> I will mark that point as done.

jakmeier added a commit to jakmeier/nearcore that referenced this issue Feb 14, 2023
Final set of tests to complement the integration tests listed in near#8467.
@jakmeier
Copy link
Contributor Author

All tests required should be coded now, just need to pass code reviews and merge them.
Good news: Everything looks like it functions as intended, I didn't find any bugs with my tests. (Only one or two misunderstanding of my own how things works.)

near-bulldozer bot pushed a commit that referenced this issue Feb 22, 2023
Final set of tests to complement the integration tests listed in #8467.
@jakmeier
Copy link
Contributor Author

All merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) T-contract-runtime Team: issues relevant to the contract runtime team
Projects
None yet
Development

No branches or pull requests

1 participant