Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAL-110 - Lock / Unlock components and workflows for encrypting accessing local storage private key #2527

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

WAL-110 - Lock / Unlock components and workflows for encrypting accessing local storage private key #2527

wants to merge 11 commits into from
+758 −164

Conversation

gutsyphilip
Copy link
Contributor

@gutsyphilip gutsyphilip commented Mar 16, 2022 •
edited
Loading

In this PR:

  • Implements idle timer for wallet
  • Implements set /change password UI
  • Implements timeout modal
  • Implements Browser password settings
  • Implements wallet unlock UI
  • Implements password reset UI
  • Implements new seedphrase input UI

image

@gutsyphilip gutsyphilip changed the title Lock / Unlock components and workflows for encrypting accessing local storage private key WAL-110 - Lock / Unlock components and workflows for encrypting accessing local storage private key Mar 16, 2022
@render
Copy link

render bot commented Mar 16, 2022

Your Render PR Server URL is https://near-wallet-pr-2527.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8p31qonlkia0dchtje0.

Patrick1904
Patrick1904 reviewed Mar 17, 2022
View reviewed changes
packages/frontend/src/components/common/Button.js
@@ -2,6 +2,26 @@ import PropTypes from 'prop-types';
import React from 'react';
import styled from 'styled-components';

const backgroundColorMap = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice mapping of colors! I'm curious why you decided to use this button component vs the regular FormButton? Seems it would be good if we used the same button as much as possible for consistency sake, and less components to maintain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely. Will switch to the FormButton.

@Patrick1904
Copy link
Contributor

@gutsyphilip is this PR ready for review? If not, can you please mark it as in progress / draft?

@gutsyphilip
Copy link
Contributor Author

@gutsyphilip is this PR ready for review? If not, can you please mark it as in progress / draft?

It was ready for review @Patrick1904. But I did the UI for the passphrase task (WAL-37) in here because it was part of the design. I'm now working to revert that and then create a separate PR for that(tied to that ticket particularly).

@Patrick1904 Patrick1904 marked this pull request as draft March 18, 2022 20:34
@Patrick1904
Copy link
Contributor

@gutsyphilip is this PR ready for review? If not, can you please mark it as in progress / draft?

It was ready for review @Patrick1904. But I did the UI for the passphrase task (WAL-37) in here because it was part of the design. I'm now working to revert that and then create a separate PR for that(tied to that ticket particularly).

Thanks for clarifying. I converted this to draft for now so please convert it back when it's ready and request a review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrick1904 Patrick1904 Patrick1904 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gutsyphilip @Patrick1904