Plotspc upgrades

[dylanbeaudette]

Integrates several ideas from #59

[brownag]

dats nice.

[brownag]

Pulled and tested latest commit. All tests passing.

[brownag]

Tests generate a warning related to not being able to delete the Rplots.pdf generated by the testing.

Also, this introduces an R CMD check warning.

  Undocumented arguments in documentation object 'plot,SoilProfileCollection,ANY-method'
    'x' 'color' 'width' 'name' 'name.style' 'label' 'hz.depths'
    'alt.label' 'alt.label.col' 'cex.names' 'cex.depth.axis' 'cex.id'
    'font.id' 'print.id' 'id.style' 'plot.order' 'relative.pos' 'add'
    'scaling.factor' 'y.offset' 'x.idx.offset' 'n' 'max.depth'
    'n.depth.ticks' 'shrink' 'shrink.cutoff' 'abbr' 'abbr.cutoff'
    'divide.hz' 'hz.distinctness.offset' 'hz.topography.lty'
    'axis.line.offset' 'plot.depth.axis' 'density' 'col.label'
    'col.palette' 'col.palette.bias' 'col.legend.cex' 'n.legend' 'lwd'
    'lty' 'default.color' '...'

[dylanbeaudette]

That is really strange: I get no errors. What platform are you on? Likely one that understands permissions.

I need to do some research on how to properly document S4 stuff with roxygen. Ideas welcome.

[brownag]

No -- this was on the work machine. I pulled the latest version of your branch and ran devtools::test(). Resulted in one warning.

I agree that it doesnt make sense that I actually didn't have permission. -- it is possible that the plot device got left open.

[brownag]

As far as ideas for how to do S4 without creating errors, I can suggest checking out this commit 35b2724 and issue #139

[brownag]

These three small commits resolve the S4 errors and uncertainties about the plot generic.

e8d4bad
0de044c
0b5ee26