Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UUID from C to Go #99

Closed
ncruces opened this issue Jun 13, 2024 · 6 comments · Fixed by #113
Closed

Move UUID from C to Go #99

ncruces opened this issue Jun 13, 2024 · 6 comments · Fixed by #113
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ncruces
Copy link
Owner

ncruces commented Jun 13, 2024

Be as compatible with uuid.c as possible. But support new UUID formats.

https://pkg.go.dev/github.com/google/uuid

@ncruces ncruces added enhancement New feature or request good first issue Good for newcomers labels Jun 13, 2024
@suyash-sneo
Copy link

Hi @ncruces. New here to OSS. I'd like to take this up and make my first contribution.

@ncruces
Copy link
Owner Author

ncruces commented Jun 14, 2024

That's great!

I'm looking for these 3 functions (more docs here):

uuid()        - generate a version 4 UUID as a string
uuid_str(X)   - convert a UUID X into a well-formed UUID string
uuid_blob(X)  - convert a UUID X into a 16-byte blob

For parsing I'm fine with just using Parse (no need to be exactly 100% compatible with the C version).

Then I'd like to (somehow) overload the uuid() to generate other kinds of UUIDs. Particularly V7, maybe just uuid(7). But other kinds would be good.

These should be helpful to get you started:

@suyash-sneo
Copy link

suyash-sneo commented Jun 15, 2024

Thanks!!
But I've never contributed to Open source and this repo doesn't have any guidelines about How to contribute that I could see.
Could you maybe provide a hint in the right direction?
That'll be super helpful

@ncruces
Copy link
Owner Author

ncruces commented Jun 15, 2024

Well, I'm not sure I can help much with that part except point to docs:
https://docs.github.com/en/get-started/exploring-projects-on-github/contributing-to-a-project

@suyash-sneo
Copy link

Sure, I'll refer to that. The material you have shared should help me get started so thanks for the help :)

@ncruces
Copy link
Owner Author

ncruces commented Jul 3, 2024

Removing the current uuid function and making it an extension is a minor breaking change.

I'd like to bundle it with #111 (another minor breaking change) before the next release.

ncruces added a commit that referenced this issue Jul 3, 2024
@ncruces ncruces mentioned this issue Jul 3, 2024
@ncruces ncruces self-assigned this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants