Skip to content

Commit

Permalink
Use artifact downloads instead of submodules (acquire-project#2)
Browse files Browse the repository at this point in the history
* Update submodules. Fix DM bugs in test_basic.py

* Update acquire-driver-common and acquire-driver-hdcam. Restore recursive submodule checkout in CI.

* Restore capital-T Tiff.

* Try to enable long paths in CI.

* Try again to enable long paths in CI.

* Update typing and dcam tests

* Update acquire-driver-common and acquire-video-runtime submodules

* update acquire-driver-zarr submodule.

* update deps, tests

* testing (wip)

* fix trigger assignment

* update submodules

* wip

* update build and test yamls

* fix packaging

* packaging: remove old setuptools options

* get dcam test to pass

* fix packaging

* build and test passes

* remove driver submodules

* update dcam and egrabber test yamls

* add GH token to environment variables in typing test.

* Clean up build script

* Address PR comments.

* update zarr sha

* update shas

---------

Co-authored-by: Nathan Clack <nclack@gmail.com>
  • Loading branch information
aliddell and nclack authored May 10, 2023
1 parent 51a7ea1 commit 6909668
Show file tree
Hide file tree
Showing 21 changed files with 265 additions and 674 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ jobs:
platform: [windows-latest, macos-latest, ubuntu-latest]

runs-on: ${{matrix.platform}}
env:
GH_TOKEN: ${{ github.token }}
steps:
- uses: actions/checkout@v3
with:
submodules: true
submodules: recursive
- uses: messense/maturin-action@v1
with:
command: build
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/test_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ jobs:

permissions:
actions: write
env:
GH_TOKEN: ${{ github.token }}
steps:
- name: Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0
Expand All @@ -29,7 +31,7 @@ jobs:

- uses: actions/checkout@v3
with:
submodules: true
submodules: recursive

- name: Set up Python ${{ matrix.python }}
uses: actions/setup-python@v4
Expand All @@ -39,7 +41,7 @@ jobs:
- name: Install
run: |
pip install --upgrade pip
pip install -e .[testing]
pip install -e '.[testing]'
- name: Test
run: |
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test_pr_dcam.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:

permissions:
actions: write
env:
GH_TOKEN: ${{ github.token }}
steps:
- name: Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0
Expand All @@ -27,7 +29,7 @@ jobs:

- uses: actions/checkout@v3
with:
submodules: true
submodules: recursive

- name: Get CMake 3.24
uses: lukka/get-cmake@latest
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test_pr_egrabber.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:

permissions:
actions: write
env:
GH_TOKEN: ${{ github.token }}
steps:
- name: Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0
Expand All @@ -27,7 +29,7 @@ jobs:

- uses: actions/checkout@v3
with:
submodules: true
submodules: recursive

- name: Get CMake 3.24
uses: lukka/get-cmake@latest
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test_typing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@ on:
jobs:
typing:
runs-on: windows-latest
env:
GH_TOKEN: ${{ github.token }}
steps:
- uses: actions/checkout@v3
with:
submodules: true
submodules: recursive

- name: Set up Python 3.10
uses: actions/setup-python@v4
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Testing
*.zarr
*.tif
*.json
Cargo.lock

# Byte-compiled / optimized / DLL files
__pycache__/
Expand Down Expand Up @@ -82,3 +83,6 @@ docs/_build/

# mypy stubgen
out/

# dotenv
.env
12 changes: 0 additions & 12 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,3 @@
path = acquire-video-runtime
url = ../acquire-video-runtime.git
branch = main
[submodule "acquire-driver-zarr"]
path = acquire-driver-zarr
url = ../acquire-driver-zarr.git
[submodule "acquire-driver-hdcam"]
path = acquire-driver-hdcam
url = ../acquire-driver-hdcam
[submodule "acquire-driver-egrabber"]
path = acquire-driver-egrabber
url = ../acquire-driver-egrabber
[submodule "acquire-driver-common"]
path = acquire-driver-common
url = ../acquire-driver-common
Loading

0 comments on commit 6909668

Please sign in to comment.