Use artifact downloads instead of submodules #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, for reference, see acquire-project/acquire-core-libs#4. |
|
@aliddell I'm seeing some interesting failures in CI. Would you mind looking? Fwiw, I'm ok w merging without passing checks here but it would be nice to understand the failures. |
aliddell
changed the title
nclack
reviewed
May 10, 2023
Closed
nclack
approved these changes
May 10, 2023
nclack
changed the title
aliddell
added a commit
to aliddell/acquire-python
that referenced
this pull request
May 11, 2023
commit 6909668 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 10 19:08:01 2023 -0400 Use artifact downloads instead of submodules (acquire-project#2) * Update submodules. Fix DM bugs in test_basic.py * Update acquire-driver-common and acquire-driver-hdcam. Restore recursive submodule checkout in CI. * Restore capital-T Tiff. * Try to enable long paths in CI. * Try again to enable long paths in CI. * Update typing and dcam tests * Update acquire-driver-common and acquire-video-runtime submodules * update acquire-driver-zarr submodule. * update deps, tests * testing (wip) * fix trigger assignment * update submodules * wip * update build and test yamls * fix packaging * packaging: remove old setuptools options * get dcam test to pass * fix packaging * build and test passes * remove driver submodules * update dcam and egrabber test yamls * add GH token to environment variables in typing test. * Clean up build script * Address PR comments. * update zarr sha * update shas --------- Co-authored-by: Nathan Clack <nclack@gmail.com>
nclack
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Update submodules. Fix DM bugs in test_basic.py * Update submodules. * Update submodules. * Expand StorageProperties to support chunking and compression parameters. * Update acquire-driver-zarr submodule. Add chunking test. * Squashed commit of the following: commit 750f6f6 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 10 10:37:05 2023 -0400 Address PR comments. commit 5a256f7 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 13:29:49 2023 -0400 Clean up build script commit a88e12a Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 13:12:43 2023 -0400 add GH token to environment variables in typing test. commit df82566 Merge: 652c401 b07cbb3 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 12:56:25 2023 -0400 Merge remote-tracking branch 'nclack/testing' into submodule-updates commit 652c401 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 12:22:45 2023 -0400 update dcam and egrabber test yamls commit 3cc7cdd Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 12:10:00 2023 -0400 remove driver submodules commit e4b9e01 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 11:51:14 2023 -0400 build and test passes commit 0b27539 Author: Nathan Clack <nclack@gmail.com> Date: Mon May 8 16:41:49 2023 -0700 fix packaging commit b07cbb3 Author: Nathan Clack <nclack@gmail.com> Date: Mon May 8 17:09:18 2023 -0700 get dcam test to pass commit bc54ff2 Author: Nathan Clack <nclack@gmail.com> Date: Mon May 8 16:57:21 2023 -0700 packaging: remove old setuptools options commit afba01d Author: Nathan Clack <nclack@gmail.com> Date: Mon May 8 16:41:49 2023 -0700 fix packaging commit a887683 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Mon May 8 17:22:09 2023 -0400 update build and test yamls commit 8e08001 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Mon May 8 17:19:31 2023 -0400 wip commit 7b3180f Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Mon May 8 16:56:02 2023 -0400 update submodules commit 6e41aff Author: Nathan Clack <nclack@gmail.com> Date: Mon May 8 10:00:42 2023 -0700 fix trigger assignment commit 9cd2915 Author: Nathan Clack <nclack@gmail.com> Date: Fri May 5 15:38:23 2023 -0700 testing (wip) commit b5bf4f9 Author: Nathan Clack <nclack@gmail.com> Date: Fri May 5 15:29:32 2023 -0700 update deps, tests commit 20ea3a0 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Thu May 4 12:24:23 2023 -0400 update acquire-driver-zarr submodule. commit 941027c Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Thu May 4 11:38:06 2023 -0400 Update acquire-driver-common and acquire-video-runtime submodules commit 5fcd566 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Thu May 4 10:55:14 2023 -0400 Update typing and dcam tests commit d68d40f Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 15:47:45 2023 -0400 Try again to enable long paths in CI. commit 34647a7 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 15:41:40 2023 -0400 Try to enable long paths in CI. commit 1d79e24 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 15:24:57 2023 -0400 Restore capital-T Tiff. commit 5b317b9 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 15:23:54 2023 -0400 Update acquire-driver-common and acquire-driver-hdcam. Restore recursive submodule checkout in CI. commit 5d170dd Merge: f989feb 51a7ea1 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 13:40:46 2023 -0400 Merge branch 'main' into submodule-updates commit 51a7ea1 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 13:38:25 2023 -0400 remove uses of PAT from workflow files, set submodules from recursive to true * Update driver hashes. * Squashed commit of the following: commit 6909668 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 10 19:08:01 2023 -0400 Use artifact downloads instead of submodules (#2) * Update submodules. Fix DM bugs in test_basic.py * Update acquire-driver-common and acquire-driver-hdcam. Restore recursive submodule checkout in CI. * Restore capital-T Tiff. * Try to enable long paths in CI. * Try again to enable long paths in CI. * Update typing and dcam tests * Update acquire-driver-common and acquire-video-runtime submodules * update acquire-driver-zarr submodule. * update deps, tests * testing (wip) * fix trigger assignment * update submodules * wip * update build and test yamls * fix packaging * packaging: remove old setuptools options * get dcam test to pass * fix packaging * build and test passes * remove driver submodules * update dcam and egrabber test yamls * add GH token to environment variables in typing test. * Clean up build script * Address PR comments. * update zarr sha * update shas --------- Co-authored-by: Nathan Clack <nclack@gmail.com> * update acquire-video-runtime * wip: update zarr driver (?) * wip * Update drivers, fix bindings, fix tests. * Misc fixes * Ran black and flake8 * fix readme
aliddell
added a commit
that referenced
this pull request
Jul 28, 2023
* Update submodules. Fix DM bugs in test_basic.py * Update submodules. * Update submodules. * Expand StorageProperties to support chunking and compression parameters. * Update acquire-driver-zarr submodule. Add chunking test. * Squashed commit of the following: commit 750f6f6 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 10 10:37:05 2023 -0400 Address PR comments. commit 5a256f7 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 13:29:49 2023 -0400 Clean up build script commit a88e12a Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 13:12:43 2023 -0400 add GH token to environment variables in typing test. commit df82566 Merge: 652c401 b07cbb3 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 12:56:25 2023 -0400 Merge remote-tracking branch 'nclack/testing' into submodule-updates commit 652c401 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 12:22:45 2023 -0400 update dcam and egrabber test yamls commit 3cc7cdd Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 12:10:00 2023 -0400 remove driver submodules commit e4b9e01 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Tue May 9 11:51:14 2023 -0400 build and test passes commit 0b27539 Author: Nathan Clack <nclack@gmail.com> Date: Mon May 8 16:41:49 2023 -0700 fix packaging commit b07cbb3 Author: Nathan Clack <nclack@gmail.com> Date: Mon May 8 17:09:18 2023 -0700 get dcam test to pass commit bc54ff2 Author: Nathan Clack <nclack@gmail.com> Date: Mon May 8 16:57:21 2023 -0700 packaging: remove old setuptools options commit afba01d Author: Nathan Clack <nclack@gmail.com> Date: Mon May 8 16:41:49 2023 -0700 fix packaging commit a887683 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Mon May 8 17:22:09 2023 -0400 update build and test yamls commit 8e08001 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Mon May 8 17:19:31 2023 -0400 wip commit 7b3180f Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Mon May 8 16:56:02 2023 -0400 update submodules commit 6e41aff Author: Nathan Clack <nclack@gmail.com> Date: Mon May 8 10:00:42 2023 -0700 fix trigger assignment commit 9cd2915 Author: Nathan Clack <nclack@gmail.com> Date: Fri May 5 15:38:23 2023 -0700 testing (wip) commit b5bf4f9 Author: Nathan Clack <nclack@gmail.com> Date: Fri May 5 15:29:32 2023 -0700 update deps, tests commit 20ea3a0 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Thu May 4 12:24:23 2023 -0400 update acquire-driver-zarr submodule. commit 941027c Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Thu May 4 11:38:06 2023 -0400 Update acquire-driver-common and acquire-video-runtime submodules commit 5fcd566 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Thu May 4 10:55:14 2023 -0400 Update typing and dcam tests commit d68d40f Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 15:47:45 2023 -0400 Try again to enable long paths in CI. commit 34647a7 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 15:41:40 2023 -0400 Try to enable long paths in CI. commit 1d79e24 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 15:24:57 2023 -0400 Restore capital-T Tiff. commit 5b317b9 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 15:23:54 2023 -0400 Update acquire-driver-common and acquire-driver-hdcam. Restore recursive submodule checkout in CI. commit 5d170dd Merge: f989feb 51a7ea1 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 13:40:46 2023 -0400 Merge branch 'main' into submodule-updates commit 51a7ea1 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 3 13:38:25 2023 -0400 remove uses of PAT from workflow files, set submodules from recursive to true * Update driver hashes. * Squashed commit of the following: commit 6909668 Author: Alan Liddell <aliddell@chanzuckerberg.com> Date: Wed May 10 19:08:01 2023 -0400 Use artifact downloads instead of submodules (#2) * Update submodules. Fix DM bugs in test_basic.py * Update acquire-driver-common and acquire-driver-hdcam. Restore recursive submodule checkout in CI. * Restore capital-T Tiff. * Try to enable long paths in CI. * Try again to enable long paths in CI. * Update typing and dcam tests * Update acquire-driver-common and acquire-video-runtime submodules * update acquire-driver-zarr submodule. * update deps, tests * testing (wip) * fix trigger assignment * update submodules * wip * update build and test yamls * fix packaging * packaging: remove old setuptools options * get dcam test to pass * fix packaging * build and test passes * remove driver submodules * update dcam and egrabber test yamls * add GH token to environment variables in typing test. * Clean up build script * Address PR comments. * update zarr sha * update shas --------- Co-authored-by: Nathan Clack <nclack@gmail.com> * update acquire-video-runtime * wip: update zarr driver (?) * wip * Update drivers, fix bindings, fix tests. * Misc fixes * Ran black and flake8 * fix readme * wip * add multiscale test * Update drivers list. * Update storage properties. * Update multiscale test. * Fix chunking tests by specifying u8 sample type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4 #5
Uses artifact downloads for drivers instead of submodules.