This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Make device name selection case-insensitive #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the things I did in the refactor was fiddle with device names, sometimes changing the case. This PR makes the regex use case insensitive matching.
A possible downside to this change is that it makes selection somewhat less specific, but I don't think we want to live in a world where "Tiff" vs "tiff" makes a meaningful difference and we should be the change we want to see.