Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portnumbers for ACK and OFFER are not correct #1

Closed
wvandervaart opened this issue Nov 10, 2020 · 1 comment
Closed

Portnumbers for ACK and OFFER are not correct #1

wvandervaart opened this issue Nov 10, 2020 · 1 comment
Assignees
@azdolinski
Labels
bug Something isn't working

Comments

@wvandervaart
Copy link

The source and destination port on these two packets are swapped.
To fix it I changed the following lines:
OLD lines:
236 sport = packet[UDP].sport
237 dport = packet[UDP].dport
279 sport = packet[UDP].sport
280 dport = packet[UDP].dport
NEW lines:
236 sport = packet[UDP].dport
237 dport = packet[UDP].sport
279 sport = packet[UDP].dport
280 dport = packet[UDP].sport
azdolinski added a commit that referenced this issue Nov 12, 2020
@azdolinski
Update ztp.py
f553d14 
Fix for #1
@azdolinski azdolinski added the bug Something isn't working label Nov 12, 2020
@azdolinski azdolinski self-assigned this Nov 12, 2020
@azdolinski
Copy link
Collaborator

Indeed... outgoing packets should have switched src<->dst port.
Fixed in 0.6b.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azdolinski azdolinski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azdolinski @wvandervaart