Fixed consume pending message calculation #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a new method `Delivered` to accurately adjust the pending message size on message delivery. Ensured pending checks and size adjustments are correctly handled during reconnect and message delivery to maintain a consistent consumer state. Also updated tests to validate these changes.
Merged
divyeshio
pushed a commit
to divyeshio/nats.net
that referenced
this pull request
Sep 13, 2024
* Fixed consume pending message calculation Implemented a new method `Delivered` to accurately adjust the pending message size on message delivery. Ensured pending checks and size adjustments are correctly handled during reconnect and message delivery to maintain a consistent consumer state. Also updated tests to validate these changes. * dotnet format
mtmk
added a commit
that referenced
this pull request
Sep 17, 2024
* Fixed consume pending message calculation (#626) * ServiceProvider callback for NATS DI configuration (#619) * Nats web socket opts improvements (#623) * Fix various disposable issues (#625) * Make NuidWriter public (#618) * NatsOpts.ConfigureWebSocketOpts callback handler (#605) * Simplified NATS client (#607) * Update docs (#595) * Add default timeout to initial commands (#594) * Extensive logging for reconnect debugging (#593) * Add clear next step navigation to API index doc (#592) * Add NATS client implementation (#589)
Merged
mtmk
added a commit
that referenced
this pull request
Sep 17, 2024
* Fixed consume pending message calculation (#626) * ServiceProvider callback for NATS DI configuration (#619) * Nats web socket opts improvements (#623) * Fix various disposable issues (#625) * Make NuidWriter public (#618) * NatsOpts.ConfigureWebSocketOpts callback handler (#605) * Simplified NATS client (#607) * Update docs (#595) * Add default timeout to initial commands (#594) * Extensive logging for reconnect debugging (#593) * Add clear next step navigation to API index doc (#592) * Add NATS client implementation (#589)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a new method
Deliveredto accurately adjust the pending message size on message delivery. Ensured pending checks and size adjustments are correctly handled during reconnect and message delivery to maintain a consistent consumer state. Also updated tests to validate these changes.resolves #608