Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST ONLY] Fixed Test_JetStreamSubscribeIdleHeartbeat #764

Merged
merged 3 commits into from
Jun 13, 2024
Merged

[TEST ONLY] Fixed Test_JetStreamSubscribeIdleHeartbeat #764

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bdde70
[TEST ONLY] Fixed Test_JetStreamSubscribeIdleHeartbeat
levb Jun 13, 2024
20b1fee
Nit: removed an irrelevant format change
levb Jun 13, 2024
92b9c7d
PR feedback: typo
levb Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 29 additions & 15 deletions test/test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27951,18 +27951,35 @@ test_JetStreamSubscribeIdleHearbeat(void)
s = js_Publish(NULL, js, "foo", "msg2", 4, NULL, &jerr);
testCond((s == NATS_OK) && (jerr == 0));

// Cheat by pretending that the server sends message seq 3, while client
// received only seq 1. Disable auto-ack for this message, or we mess up the
// server state.
#define PUBLISH_FAKE_JS_MSG_WITH_SEQ(_reply, _msg) \
{ \
natsSub_Lock(sub); \
inbox = sub->subject; \
sub->jsi->ackNone = true; \
natsSub_Unlock(sub); \
\
natsConn_setFilterWithClosure(nc, _setMsgReply, (void *)(_reply)); \
s = natsConnection_PublishString(nc, inbox, (_msg)); \
}

#define PUBLISH_FAKE_RESET() \
{ \
natsSub_Lock(sub); \
sub->jsi->ackNone = false; \
levb marked this conversation as resolved.
Show resolved Hide resolved
natsSub_Unlock(sub); \
}

test("Check seq mismatch: ");
natsSub_Lock(sub);
inbox = sub->subject;
natsSub_Unlock(sub);
// Cheat by pretending that the server sends message seq 3, while client received only seq 1.
natsConn_setFilterWithClosure(nc, _setMsgReply, (void*) "$JS.ACK.TEST.dur1.1.3.3.1624472520000000000.0");
s = natsConnection_PublishString(nc, inbox, "msg3");
PUBLISH_FAKE_JS_MSG_WITH_SEQ("$JS.ACK.TEST.dur1.1.3.3.1624472520000000000.0", "msg3 fake");
// Wait for past the next HB and we should get an async error
natsMutex_Lock(args.m);
while ((s != NATS_TIMEOUT) && !args.done)
s = natsCondition_TimedWait(args.c, args.m, 300);
natsMutex_Unlock(args.m);
PUBLISH_FAKE_RESET();
testCond(s == NATS_OK);

test("Check that notification is sent only once: ");
Expand Down Expand Up @@ -27996,15 +28013,15 @@ test_JetStreamSubscribeIdleHearbeat(void)
testCond(s == NATS_OK);

test("Skip again: ");
natsConn_setFilterWithClosure(nc, _setMsgReply, (void*) "$JS.ACK.TEST.dur1.1.4.4.1624482520000000000.0");
s = natsConnection_PublishString(nc, inbox, "msg4");
PUBLISH_FAKE_JS_MSG_WITH_SEQ("$JS.ACK.TEST.dur1.1.4.4.1624482520000000000.0", "msg4 fake");
testCond(s == NATS_OK);

test("Check async cb invoked: ");
natsMutex_Lock(args.m);
while ((s != NATS_TIMEOUT) && !args.done)
s = natsCondition_TimedWait(args.c, args.m, 1000);
natsMutex_Unlock(args.m);
PUBLISH_FAKE_RESET();
testCond(s == NATS_OK);

test("Check HB timer reports missed HB: ");
Expand Down Expand Up @@ -28059,11 +28076,7 @@ test_JetStreamSubscribeIdleHearbeat(void)
nats_clearLastError();

test("Skip: ");
natsSub_Lock(sub);
inbox = sub->subject;
natsSub_Unlock(sub);
natsConn_setFilterWithClosure(nc, _setMsgReply, (void*) "$JS.ACK.TEST.dur2.1.4.4.1624482520000000000.0");
s = natsConnection_PublishString(nc, inbox, "msg4");
PUBLISH_FAKE_JS_MSG_WITH_SEQ("$JS.ACK.TEST.dur2.1.4.4.1624482520000000000.0", "msg4 fake");
testCond(s == NATS_OK);

// For sync subs, we should not get async error
Expand All @@ -28074,6 +28087,7 @@ test_JetStreamSubscribeIdleHearbeat(void)
natsMutex_Unlock(args.m);
testCond(s == NATS_TIMEOUT);
nats_clearLastError();
PUBLISH_FAKE_RESET();

test("NextMsg reports error: ");
s = natsSubscription_NextMsg(&msg, sub, 1000);
Expand Down Expand Up @@ -28103,15 +28117,15 @@ test_JetStreamSubscribeIdleHearbeat(void)
testCond(s == NATS_OK);

test("Skip again: ");
natsConn_setFilterWithClosure(nc, _setMsgReply, (void*) "$JS.ACK.TEST.dur1.1.5.5.1624492520000000000.0");
s = natsConnection_PublishString(nc, inbox, "msg5");
PUBLISH_FAKE_JS_MSG_WITH_SEQ("$JS.ACK.TEST.dur1.1.5.5.1624492520000000000.0", "msg5 fake");
testCond(s == NATS_OK);

test("NextMsg reports error: ");
nats_Sleep(300);
s = natsSubscription_NextMsg(&msg, sub, 1000);
testCond((s == NATS_MISMATCH) && (msg == NULL));
nats_clearLastError();
PUBLISH_FAKE_RESET();

test("Check HB timer reports missed HB: ");
s = NATS_OK;
Expand Down