[TEST ONLY] Fixed Test_JetStreamSubscribeIdleHeartbeat #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
+ Coverage 68.68% 68.70% +0.01%
==========================================
Files 39 39
Lines 15186 15186
Branches 3139 3139
==========================================
+ Hits 10431 10434 +3
+ Misses 1702 1699 -3
Partials 3053 3053 ☔ View full report in Codecov by Sentry. |
mtmk
reviewed
Jun 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
…ribeIdleHeartbeat (#764)
levb
added a commit
that referenced
this pull request
Oct 1, 2024
* [TEST ONLY] Fixed Test_JetStreamSubscribeIdleHeartbeat * Nit: removed an irrelevant format change * PR feedback: typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nats-io/nats-server/pull/5482/files#diff-c6e9a3ce0d55948f2e7ea75a4de309986654f2ab11e0f8750625b88b28bd9ebfR2833-R2838 broke this test. The test was faking a JetStream-delivered message, resulting in inaccurate ACKs being sent to the server. Disabled auto-ACKs for the relevant messages to avoid messing up the server state, and the test is now passing.