Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Set ReadTimeout on profiling, monitoring and OCSP HTTP servers #5790

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[IMPROVED] Set ReadTimeout on profiling, monitoring and OCSP HTTP servers #5790

merged 1 commit into from
Aug 15, 2024

Conversation

neilalexander
Copy link
Member

Reported-by: Trail of Bits https://www.trailofbits.com
Signed-off-by: Neil Twigg neil@nats.io

@neilalexander neilalexander requested a review from a team as a code owner August 14, 2024 13:31
@derekcollison
Copy link
Member

@neilalexander let's make sure CI is green.

I think this test is failing consistently.

TestMonitoringNoTimeout

@neilalexander
Copy link
Member Author

I've changed the monitoring port from ReadTimeout to ReadHeaderTimeout since seemingly the TestMonitoringNoTimeout checks ReadTimeout isn't set. This will mitigate the issue still.

@derekcollison
Copy link
Member

Please make sure builds are green..

This test needs updating?

TestProfilingNoTimeout

@neilalexander
Set ReadTimeout on profiling and OCSP HTTP servers, `ReadHeaderTime…
46ec35a 
…out` on monitoring HTTP server

Reported-by: Trail of Bits <https://www.trailofbits.com>
Signed-off-by: Neil Twigg <neil@nats.io>
derekcollison
derekcollison approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit bd9de78 into main Aug 15, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/slowloris branch August 15, 2024 22:08
@wallyqs wallyqs mentioned this pull request Aug 23, 2024
Merged
@wallyqs wallyqs changed the title Set ReadTimeout on profiling, monitoring and OCSP HTTP servers [IMPROVED] Set ReadTimeout on profiling, monitoring and OCSP HTTP servers Aug 23, 2024
wallyqs added a commit that referenced this pull request Aug 23, 2024
@wallyqs
Cherry picks for v2.10.19 RC5 (#5823)
26c8196 
Includes:

  - #5782
  - #5785
  - #5757
  - #5789
  - #5790
  - #5793
  - #5794
  - #5809
  - #5812
  - #5816
  - #5819
  - #5818
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs left review comments

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilalexander @derekcollison @wallyqs