Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stree: Make Iter faster by using generic sorting function #5734

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

neilalexander
Copy link
Member

This is roughly 4x faster since there are no interface conversions and reduces allocations.

Signed-off-by: Neil Twigg neil@nats.io

This is roughly 4x faster since there are no interface conversions
and reduces allocations.

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner August 1, 2024 14:37
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 136ef66 into main Aug 1, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/streesort branch August 1, 2024 17:22
neilalexander added a commit that referenced this pull request Aug 6, 2024
Includes the following:

- #5690
- #5725
- #5729
- #5734
- #5735
- #5736
- #5743
- #5744
- #5751
- #5755
- #5754
- #5732
- #5750
- #5756

The following were reverted before this PR:
- #5602

Signed-off-by: Neil Twigg <neil@nats.io>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants