Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #118, Resolve LGTM warnings #119

Merged
merged 6 commits into from
Aug 5, 2020
Merged

Fix #118, Resolve LGTM warnings #119

merged 6 commits into from
Aug 5, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jul 27, 2020

Describe the contribution
Fix #118

  • Resolves commented out code warnings
  • Resolves unused packages in hand generated code

Testing performed
Sent commands and viewed telemetry

Expected behavior changes
Resolve LGTM warnings on analysis

System(s) tested on

  • Hardware: cFS Dev VM
  • OS: Ubuntu 18.04
  • Versions: current bundle

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

astrogeco and others added 6 commits May 29, 2020 18:46
@astrogeco
Merge pull request nasa#94 from nasa/integration-candidate
3263506 
Integration candidate: 2020-05-20
@astrogeco
Merge pull request nasa#101 from nasa/integration-candidate
52f706b 
Integration Candidate: 2020-05-27
@astrogeco
Merge pull request nasa#107 from nasa/integration-candidate
9cd5304 
Integration Candidate: 2020-06-17
@skliper
Update README.md
defa816
@astrogeco
Merge pull request nasa#109 from nasa/integration-candidate
2cdf182 
Integration Candidate: 2020-06-24
@skliper
Fix nasa#118, Resolve LGTM warnings
c377629 
- Resolves commented out code warnings
- Resolves unused packages in hand generated code
@skliper skliper added CCB:FastTrack enhancement New feature or request labels Jul 27, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2020

This pull request fixes 2 alerts when merging c377629 into 2cdf182 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@astrogeco astrogeco added IC-20200729 CCB:Approved Indicates approval by CCB labels Aug 5, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate August 5, 2020 02:43
@astrogeco astrogeco merged commit d6bcef6 into nasa:integration-candidate Aug 5, 2020
@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2020

This pull request fixes 2 alerts when merging c377629 into c22f00e - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@astrogeco astrogeco mentioned this pull request Aug 5, 2020
Merged
@skliper skliper added this to the 2.2.0 milestone Aug 21, 2020
@skliper skliper deleted the fix118-resolve-lgtm-issues branch February 1, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrogeco astrogeco astrogeco approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates approval by CCB CCB:FastTrack enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Clean a few LGTM issues
2 participants
@skliper @astrogeco