Merge pull request #119 from skliper/fix118-resolve-lgtm-issues

Fix #118, Resolve LGTM warnings
nasa · Aug 5, 2020 · d6bcef6 · d6bcef6
2 parents 9b05270 + c377629
commit d6bcef6
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 18 deletions.
diff --git a/Subsystems/cmdGui/Parameter.py b/Subsystems/cmdGui/Parameter.py
@@ -20,8 +20,6 @@
 import getopt
 import pickle
 import re
-import shlex
-import subprocess
 import sys
 from pathlib import Path
 
@@ -68,12 +66,6 @@ def ProcessSendButton(self):
         self.mcu = MiniCmdUtil(pageAddress, pagePort, pageEndian, pagePktId,
                                cmdCode, param_string.strip())
         sendSuccess = self.mcu.sendPacket()
-        # launch_string = (
-        #     f'{ROOTDIR.parent}/cmdUtil/cmdUtil --host={pageAddress} '
-        #     f'--port={pagePort} --pktid={pagePktId} --endian={pageEndian} '
-        #     f'--cmdcode={cmdCode} {param_string.strip()}')result
-        # cmd_args = shlex.split(launch_string)
-        # subprocess.Popen(cmd_args)
         if sendSuccess:
             self.status_box.setText('Command sent!')
         else:

diff --git a/Subsystems/cmdGui/UdpCommands.py b/Subsystems/cmdGui/UdpCommands.py
@@ -58,11 +58,6 @@ def __init__(self):
         self.setWindowTitle(pageTitle)
         self.mcu = None
 
-        # for j in range(self.tblCommands.rowCount()):
-        #     btn = self.tblCommands.cellWidget(j, 1)
-        #     btn.clicked.connect(
-        #         lambda _, x=j: self.ProcessSendButtonGeneric(x))
-
     #
     # Determines if command requires parameters
     #

diff --git a/Subsystems/tlmGUI/TelemetrySystem.py b/Subsystems/tlmGUI/TelemetrySystem.py
@@ -50,11 +50,6 @@ def __init__(self):
         self.pktCount = 0
         self.subscription = None
 
-        # for k in range(21):
-        #     pushButton = getattr(self, f"pushButton_{k}")
-        #     pushButton.clicked.connect(
-        #         lambda _, x=k: self.ProcessButtonGeneric(x))
-
     #
     # convert a string of binary bytes to ascii hex
     #