Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #886, library table id management #887

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fix #886, library table id management #887

merged 1 commit into from
Sep 17, 2020

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Apply the appid/taskid/counterid pattern to Library resources.

Testing performed
Build and sanity check CFE, ensure library is loaded correctly
Run all unit tests

Expected behavior changes
No impact to behavior. Internal change only.

System(s) tested on
Ubuntu 20.04

Additional context
Implement the same pattern on Library IDs which was previously implemented for apps, tasks, and counters.

For unit testing this also moves the Library-specific UT calls into a separate function.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey
Fix nasa#886, library table management
16e2c0e 
Apply the appid/taskid pattern to Library resources.
No real logic change - just putting repeated logic into
inline functions.
@jphickey
Copy link
Contributor Author

Also note that this cleans up a previously leftover debug #ifdef in UT code while also moving the code to a separate function.

@jphickey jphickey linked an issue Sep 14, 2020 that may be closed by this pull request
Update Library code to decouple IDs from table indices #886
Closed
@jphickey jphickey added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) enhancement labels Sep 14, 2020
CDKnightNASA
CDKnightNASA approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@CDKnightNASA CDKnightNASA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create a ticket to define typedefs for ID's and return status codes. For now they can be simple typedefs to the uint32 type but eventually should be wrapped or otherwise we should have a mechanism to ensure that they're not misused.

@jphickey
Copy link
Contributor Author

I will create a ticket to define typedefs for ID's and return status codes. For now they can be simple typedefs to the uint32 type but eventually should be wrapped or otherwise we should have a mechanism to ensure that they're not misused.

Sounds good - this was on my eventual plans too. If you write tickets I only request they are separate ones (typedef for ids, typedef for returns) as each is a separate dev effort to do.

@astrogeco
Copy link
Contributor

CCB 2020-09-16 APPROVED

@yammajamma yammajamma added CCB-20200916 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Sep 16, 2020
@yammajamma yammajamma merged commit 36695e9 into nasa:integration-candidate Sep 17, 2020
@yammajamma yammajamma mentioned this pull request Sep 17, 2020
Merged
@jphickey jphickey deleted the fix-886-library-table branch September 29, 2020 21:52
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CDKnightNASA CDKnightNASA CDKnightNASA approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

Update Library code to decouple IDs from table indices
5 participants
@jphickey @astrogeco @CDKnightNASA @skliper @yammajamma