Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Library code to decouple IDs from table indices #886

Closed
jphickey opened this issue Sep 14, 2020 · 0 comments · Fixed by #887 or #891
Closed

Update Library code to decouple IDs from table indices #886

jphickey opened this issue Sep 14, 2020 · 0 comments · Fixed by #887 or #891
Labels
enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Library IDs are currently coupled to the Library table index.

Describe the solution you'd like
Library IDs should be opaque values and not interpreted directly as a table index.
Apply the same pattern as in previous PRs #859 and #871 to the Library code.

Additional context
Part of ongoing effort to clean up IDs across all of ES.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/cFE that referenced this issue Sep 14, 2020
@jphickey
Fix nasa#886, library table management
16e2c0e 
Apply the appid/taskid pattern to Library resources.
No real logic change - just putting repeated logic into
inline functions.
@jphickey jphickey linked a pull request Sep 14, 2020 that will close this issue
Fix #886, library table id management #887
Merged
yammajamma added a commit that referenced this issue Sep 17, 2020
@yammajamma
Merge pull request #887 from jphickey/fix-886-library-table
36695e9 
Fix #886, library table id management
@yammajamma yammajamma mentioned this issue Sep 17, 2020
Merged
@astrogeco astrogeco added this to the 7.0.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #886, library table id management jphickey/cFE
Integration Candidate: 2020-09-16 nasa/cFE
3 participants
@jphickey @skliper @astrogeco