Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate: 2020-08-26 #849

Merged
merged 13 commits into from
Sep 1, 2020
Merged

Integration Candidate: 2020-08-26 #849

merged 13 commits into from
Sep 1, 2020

Conversation

yammajamma
Copy link
Contributor

@yammajamma yammajamma commented Aug 27, 2020

Describe the contribution
Fix #798
Fix #818
Fix #822
Fix #825
Fix #831
Fix #836

Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/134/checks

Expected behavior changes
PR #799 - Removes reference from documentation.

PR #834 - CFE_SB_SendMsg stub now behaves the same as CFE_SB_TimeStampMsg (copies message pointer from local). No longer need to emulate CFE_SB_InitMsg from test code, set the API/stub data buffers directly.

PR #826 - Removed iterator modification from within the loop... replaced with break.

PR #832 - Resolves loop iterator size too small for comparison.

PR #842 - Replaced CFE_MISSION_SPACECRAFT_ID use with CFE_PSP_GetSpacecraftId() and updated unit test

System(s) tested on
Ubuntu - CI

Additional context
nasa/cFS#134

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC

@yammajamma yammajamma merged commit 08f6eab into main Sep 1, 2020
astrogeco pushed a commit to nasa/cFS that referenced this pull request Sep 2, 2020
@astrogeco astrogeco added this to the 7.0.0 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment