Fix #818, Return message address from CFE_SB_SendMsg stub #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
CCB:Ready
|
CCB 2020-08-26 - APPROVED |
astrogeco
removed
the
CCB:Ready
yammajamma
added
IC-20200826
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #818, CFE_SB_SendMsg stub now behaves the same as CFE_SB_TimeStampMsg (copies message pointer from local)
Fix #825, No longer need to emulate CFE_SB_InitMsg from test code, set the API/stub data buffers directly.
Testing performed
Built with tests, tests ran and passed. Depends on update to unit test in sample_app, nasa/sample_app#90.
Expected behavior changes
Stub returns message address instead of copy of message.
System(s) tested on
Additional context
nasa/sample_app#90
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC