Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #676, reference to deprecated CFE_SPACECRAFT_ID #677

Merged

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented May 6, 2020

Describe the contribution
Change to CFE_MISSION_SPACECRAFT_ID, which is the non-deprecated symbol.

Fixes #676

Testing performed
Build with extended header and OMIT_DEPRECATED and confirm success.

Expected behavior changes
Build now works with both extended headers and OMIT_DEPRECATED options set.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Should be CFE_MISSION_SPACECRAFT_ID
@jphickey jphickey added bug CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 6, 2020
@skliper skliper added CCB-20200506 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 6, 2020
@skliper
Copy link
Contributor

skliper commented May 6, 2020

CCB 20200506 - Approved

@skliper skliper added this to the 6.8.0 milestone May 7, 2020
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB IC-20200429 labels May 8, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 8, 2020 18:12
@astrogeco astrogeco merged commit 492664b into nasa:integration-candidate May 8, 2020
@jphickey jphickey deleted the fix-676-fix-deprecated-symbol branch May 21, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference to deprecated symbol when extended header enabled
3 participants