Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference to deprecated symbol when extended header enabled #676

Closed
jphickey opened this issue May 6, 2020 · 0 comments · Fixed by #677 or #692
Closed

Reference to deprecated symbol when extended header enabled #676

jphickey opened this issue May 6, 2020 · 0 comments · Fixed by #677 or #692
Assignees
@jphickey
Labels
bug
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

jphickey commented May 6, 2020

Describe the bug
If MESSAGE_FORMAT_IS_CCSDS_VER_2 is defined then this references a deprecated symbol and fails to build when OMIT_DEPRECATED is also set.

To Reproduce
Build with both MESSAGE_FORMAT_IS_CCSDS_VER_2 mission config and OMIT_DEPRECATED compile option.

Expected behavior
Should build successfully.

System observed on:
Ubuntu 20.04

Reporter Info
Joseph Hickey, Vantage Systems, Inc
jphickey added a commit to jphickey/cFE that referenced this issue May 6, 2020
@jphickey
Fix nasa#676, reference to deprecated CFE_SPACECRAFT_ID
7c17fd8 
Should be CFE_MISSION_SPACECRAFT_ID
@jphickey jphickey mentioned this issue May 6, 2020
Merged
@skliper skliper added the bug label May 7, 2020
@skliper skliper added this to the 6.8.0 milestone May 7, 2020
astrogeco added a commit that referenced this issue May 8, 2020
@astrogeco
Merge pull request #677 from jphickey/fix-676-fix-deprecated-symbol
492664b 
Fix #676, reference to deprecated CFE_SPACECRAFT_ID
@astrogeco astrogeco mentioned this issue May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Bootes
2 participants
@jphickey @skliper