Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1769, add call to CFE_ES_ExitChildTask #1877

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Invoke CFE_ES_ExitChildTask from the main test task, to confirm that the task does not actually exit. There is no status code
but the fact that the test keeps running is evidence that the task did not exit (which means the test passed).

Fixes #1769

Testing performed
Build and run CFE functional test

Expected behavior changes
Adds test case for CFE_ES_ExitChildTask being called from main task (no actual effect, request is rejected, task does not exit).

System(s) tested on
Ubuntu

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 24, 2021
Invoke CFE_ES_ExitChildTask from the main test task, to confirm
that the task does not actually exit.  There is no status code
but the fact that the test keeps running is evidence that the
task did not exit (which means the test passed).
@jphickey
Copy link
Contributor Author

Just pushed a minor update to put the check inside the "TestExitChildTask" function. (Same check, code not changed, just moved where it appears in the test log to make it more coherent).

@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 25, 2021
@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Aug 25, 2021
@astrogeco
Copy link
Contributor

CCB:2021-08-25 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate August 27, 2021 15:58
@astrogeco astrogeco merged commit 97f39b6 into nasa:integration-candidate Aug 27, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 27, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 1, 2021
**Combines**

nasa/cFE#1885,              v6.8.0-rc1+dev980
nasa/osal#1138,             v5.1.0-rc1+dev598
nasa/cFS-GroundSystem#195,  v2.2.0-rc1+dev63

**Includes**

*cFE*

nasa/cFE#1870, Add SB API test cases
nasa/cFE#1869, Add ES API test cases
nasa/cFE#1872, Add TBL API test cases
nasa/cFE#1871, Add FS API test cases
nasa/cFE#1860, Add Time Clock Test
nasa/cFE#1862, EVS coverage test
nasa/cFE#1876, SB test improvements
nasa/cFE#1865, CFE_TBL_Modified: Test CRC, updated flag
nasa/cFE#1881, Improve EVS code coverage
nasa/cFE#1877, add call to CFE_ES_ExitChildTask
nasa/cFE#1902, Incorrect OSAL Format in Users Guide Reference
nasa/cFE#1884, Improve FS coverage
nasa/cFE, Improve MSG branch coverage
nasa/cFE#1891, Improve resource ID branch coverage
nasa/cFE#1894, Improve SBR branch coverage
nasa/cFE#1896, Fix #1895, Improve TIME branch coverage
nasa/cFE#1904, Improve TBL code coverage
nasa/cFE#1864, Support custom PSP directory
nasa/cFE#1913, Update time tests to use bitmask check macros
nasa/cFE#1923, remove extra word in comment

*osal*

nasa/osal#1136, add bitmask assert macros

*cFS-GroundSystem*

nasa/cFS-GroundSystem#190, Fix #189, Virtualenv and Pipenv .gitignore support
nasa/cFS-GroundSystem#194, Fix doc, comment, and message typos

Co-authored-by: Jacob Hageman           <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey           <jphickey@users.noreply.github.com>
Co-authored-by: Alex Campbell           <zanzaben@users.noreply.github.com>
Co-authored-by: Ariel Adams             <ArielSAdamsNASA@users.noreply.github.com>
Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
Co-authored-by: Avi                     <thnkslprpt@users.noreply.github.com>
Co-authored-by: Paul                    <pavll@users.noreply.github.com>
@jphickey jphickey deleted the fix-1769-exitchildtask branch September 13, 2021 16:50
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
4 participants