Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bug
This bug happens for every number that ends with .29, .57, .58
Because when these numbers are multiplied by 100, they become
The issue is at rounding down the Satang to 2 digits which cause the inaccuracy
This pull request
String
Before:
After:
This will fix for all strings, and it also appeared to be a bit faster than before
Number
Before:
After:
This will now fix for most of the numbers, theoretically, it should work up to around 10^12-14
For performance, based on the benchmark, it does not have much difference.