Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequencer improvements #29

Merged
merged 21 commits into from
Aug 30, 2024
Merged

Sequencer improvements #29

merged 21 commits into from
Aug 30, 2024

Conversation

TimGroeneboom
Copy link
Contributor

See video for demonstration. Build & run sequencer demo to observe changes

  • added undo / redo / rollback system
  • added coloring of segments
  • adding the ability to lock segments, preventing them from moving on the track
  • adding the ability to hit CTRL and move complete track from the drag position or just dragging one segment
sequencer_upgrade.mp4

@cklosters
Copy link
Member

Thanks for the PR, I'll have time to properly review it beginning of next month.

@cklosters cklosters added enhancement New feature or request sequencer Sequencer related Questions & Issues labels Jul 29, 2024
Copy link
Member

@cklosters cklosters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, my only concern relates to deserializatrion of pointers & threading - see review comments

@cklosters
Copy link
Member

cklosters commented Aug 13, 2024

When I drag an event (make an edit) and try to re-load the change I get the following assert (Debug / MSVC):

history_edit_error.mp4

@TimGroeneboom
Copy link
Contributor Author

When I drag an event (make an edit) and try to re-load the change I get the following assert (Debug / MSVC):

history_edit_error.mp4

good catch, weird the crash only occurs on msvc.

fix pushed -> 7c3fd05

@cklosters
Copy link
Member

Thanks for the clarification @TimGroeneboom, this PR will be part of the 0.7.5 release and can be merged into main when the builds pass.

@cklosters cklosters merged commit a63b984 into main Aug 30, 2024
3 checks passed
@cklosters
Copy link
Member

Merci! feel free to delete branch if you don't need it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sequencer Sequencer related Questions & Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants