-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequencer improvements #29
Conversation
Thanks for the PR, I'll have time to properly review it beginning of next month. |
…r to change inputTexts and press space-bar without immidiatly triggering a pause/play
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change, my only concern relates to deserializatrion of pointers & threading - see review comments
When I drag an event (make an edit) and try to re-load the change I get the following assert (Debug / MSVC): history_edit_error.mp4 |
good catch, weird the crash only occurs on msvc. fix pushed -> 7c3fd05 |
…encer_development
Thanks for the clarification @TimGroeneboom, this PR will be part of the 0.7.5 release and can be merged into main when the builds pass. |
Merci! feel free to delete branch if you don't need it anymore. |
See video for demonstration. Build & run sequencer demo to observe changes
sequencer_upgrade.mp4