Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some use case in the readme #13

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

DanChaltiel
Copy link
Contributor

Here is a proposal for use cases in the documentation.

This is in line with #12

I never use base plots so you might be able to come with a better syntax (I thought it was nice to show it too).

I edited this directly on GitHub so I did not knit the Rmd to md.

I used eval=FALSE but you might choose otherwise.

As it seems that you are not using GitHub actions to generate pkgdown (you should give it a try, it is very nice!), you might also need to re-run your workflow manually.

Thanks again for your package!

@nanxstats nanxstats self-requested a review March 8, 2023 01:11
Copy link
Owner

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Let's merge this. I'm going to move this note to a dedicated FAQ vignette later.

@nanxstats nanxstats merged commit 65a5aad into nanxstats:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants