Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wallet logging initialization #4680

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

pwojcikdev
Copy link
Contributor

This fixes the crash happening when running graphical nano wallet, reported here #4679. Thanks @milahu for finding the root of the problem!

This also highlights that nano_wallet executable is not being run as part of our CI, which should be fixed.

@pwojcikdev pwojcikdev merged commit fbcabb2 into nanocurrency:develop Jul 16, 2024
25 of 28 checks passed
@qwahzi qwahzi added this to the V27 milestone Jul 16, 2024
@milahu
Copy link

milahu commented Jul 16, 2024

thanks for the quick fix : )

bad news: same problem with nano_rpc

$ ./result/bin/nano_rpc --help
Assertion (global_initialized) failed
nano::logger::logger(std::string)
/build/source/nano/lib/logging.cpp:220
Error: logging should be initialized before creating a logger

 0# 0x00000000005B5357 in ./result/bin/nano_rpc
 1# 0x00000000005AF0F8 in ./result/bin/nano_rpc
 2# 0x000000000055F6D2 in ./result/bin/nano_rpc
 3# 0x000000000049990A in ./result/bin/nano_rpc
 4# __libc_start_main in /nix/store/apab5i73dqa09wx0q27b6fbhd1r18ihl-glibc-2.39-31/lib/libc.so.6
 5# 0x000000000049E475 in ./result/bin/nano_rpc

Aborted (core dumped)

@milahu
Copy link

milahu commented Jul 18, 2024

same problem with nano_rpc

bounty: 24.652298XNO = $24.01 paid in advance
bitback.me/pwojcikdev ...?

edit: revoke. nano_rpc is just an rpc client (?) and i was looking for
nano_node --daemon --config rpc.enable=true

(but i still could use some help with basicswap/basicswap#106)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants