Merge server_socket in to tcp_listener #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The removing of the delay in accepting sockets should really be in a separate PR. It is a feature change whereas the server socket removal is a refactoring. |
clemahieu
force-pushed
the
socket_threads
branch
from
4df232f
to
32ba010
Compare
… attach a boost tcp acceptor to the socket class. It made no use of socket functionality.
…Removing virtual functions from the nano::socket class and marking it as final.
clemahieu
force-pushed
the
socket_threads
branch
from
32ba010
to
a66787a
Compare
|
Removed commit which modified socket timeouts. Added an additional commit which removed client_socket which was just a passthrough for socket. Marked socket as final and removed virtual functions. |
pwojcikdev
approved these changes
Jan 9, 2024
dsiganos
reviewed
Jan 9, 2024
This was copied from the socket class but that's a good point, I'll see if that can be removed. |
dsiganos
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges server_socket into tcp_listener. Functionality from nano::socket wasn't being used within nano::server_socket except for using the inherited boost strand. tcp_listener is changed to derive from shared_from_this since it's captured in network operation callbacks as sever_socket was previously.
Removes delays when dropping connections due to IP limits.
Improves unit test assertions.