Fix performance issue in block_uniquer cleanup. #4326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
force-pushed
the
fix_block_uniquer_linear_scan
branch
2 times, most recently
from
e86299d
to
1bb5ca7
Compare
The entire container is now cleaned periodically instead of the previous, more complex way.
clemahieu
force-pushed
the
fix_block_uniquer_linear_scan
branch
from
1bb5ca7
to
0c78b06
Compare
pwojcikdev
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random item selection is now done based on buckets of unordered_map rather than iterating a random number of values. Previously this was doing a linear scan of entries in nano::block_uniquer::blocks which had a significant performance impact.