Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This creates a the nano::store library/namespace/directory #4286

Merged
merged 7 commits into from
Sep 20, 2023

Conversation

clemahieu
Copy link
Contributor

@clemahieu clemahieu commented Sep 19, 2023

Commits should be reviewed in sequence as they're grouped by change concept.

Major components that went into this PR:

  • Clearing nano::store for use as a namespace by renaming nano::store to nano::store::component
  • Moving nano::store header files and updating includes in implementation files
  • Moving nano::store implementation files
  • Extracting classes from large files into new files
  • Renaming namespaces and classes

Move files to their new location with as few commits and as early as possible
Move files without modification to maintain history and mitigate merge conflicts
Don't move a file and change a file in the same commit

@clemahieu clemahieu force-pushed the nano_store_lib branch 8 times, most recently from 520f705 to 3478a7a Compare September 20, 2023 03:55
@clemahieu clemahieu marked this pull request as ready for review September 20, 2023 04:48
@clemahieu clemahieu merged commit ea7713a into nanocurrency:develop Sep 20, 2023
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant