Applies a number of cleanups to rpc tests. #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
force-pushed
the
rpc_test_pending_cleanup
branch
from
52c73e5
to
0469bfa
Compare
… several separate concepts and was difficult to debug because of its size and variable interactions.
clemahieu
force-pushed
the
rpc_test_pending_cleanup
branch
from
0469bfa
to
db26e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting a portion of tests off in to their own files to reduce compile times which were becoming noticeable and makes debugging harder.
Splits the rpc.receivable test in to several separate smaller tests. Test complexity was hindering analysis.