Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nano pow server #4043

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Remove nano pow server #4043

merged 4 commits into from
Jan 13, 2023

Conversation

dsiganos
Copy link
Contributor

Remove nano-pow-server and any references to it

resolves #4042

@dsiganos
Remove nano-pow-server from git and cmake files
e5e352b 
Remove nano-pw-server from git repo and from cmake files.
@dsiganos
Remove commented out code that used to spawn nano-pow-server
9adaff8 
We are rmeoving nano-pow-server so it is not relevant anymore.
@dsiganos
Remove any references to nano-pow-server
cf1498d 
The nano node and the nano wallet used to have options to spawn
nano-pow-server.

And there were config settings for nano-pow-server for enabling and
settings paths.
@dsiganos
Remove references to nano-pow-server from build scripts
22d6747
@dsiganos dsiganos merged commit 48edec9 into nanocurrency:develop Jan 13, 2023
@dsiganos dsiganos deleted the remove-nano-pow-server branch January 13, 2023 12:38
@thsfs thsfs added removal Indicates functionality is being removed documentation This item indicates the need for or supplies updated or expanded documentation labels Mar 1, 2023
@thsfs
Copy link
Contributor

thsfs commented Mar 1, 2023

Added a documentation label so we remember double checking if any doc change is required.

@thsfs thsfs added the docker updates and changes to the docker build image label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

@pwojcikdev pwojcikdev Awaiting requested review from pwojcikdev

@thsfs thsfs Awaiting requested review from thsfs

Assignees
No one assigned
Labels
docker updates and changes to the docker build image documentation This item indicates the need for or supplies updated or expanded documentation removal Indicates functionality is being removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove nano-pow-server from nano-node git repo and docker
3 participants
@dsiganos @thsfs @clemahieu