Change election scheduler to consider previous balance #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revious block's balances and prioritize to the max of both.
…accept the priority value in prioritization::push.
clemahieu
force-pushed
the
scheduler_balance_max
branch
from
0b4429f
to
8b1b5ba
Compare
clemahieu
added a commit
that referenced
this pull request
Dec 9, 2022
* Teach the scheduler priority queue to consider both the block's and previous block's balances and prioritize to the max of both. * Move priority calculations in to the election_scheduler and directly accept the priority value in prioritization::push.
mistakia
pushed a commit
to mistakia/nano-community
that referenced
this pull request
Jan 3, 2023
* Update protocol-reference.md with V24 bucket info Updating from 129 to 62 buckets, per: nanocurrency/nano-node#3980 Updating from current block balance to max of current or previous, per: nanocurrency/nano-node#4022 * Update protocol-reference prioritization notable functions Update protocol-reference.md Election Scheduler section with election_scheduler::activate notable function & adjust wording for pre vs post V24 clarity * Update protocol reference link to tagged vs develop Update protocol reference link to a more static tagged release instead of the develop branch (which can change)
thsfs
added
the
functionality quality improvements
ATXMJ
pushed a commit
to ATXMJ/nano-community
that referenced
this pull request
Sep 16, 2024
* Update protocol-reference.md with V24 bucket info Updating from 129 to 62 buckets, per: nanocurrency/nano-node#3980 Updating from current block balance to max of current or previous, per: nanocurrency/nano-node#4022 * Update protocol-reference prioritization notable functions Update protocol-reference.md Election Scheduler section with election_scheduler::activate notable function & adjust wording for pre vs post V24 clarity * Update protocol reference link to tagged vs develop Update protocol reference link to a more static tagged release instead of the develop branch (which can change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change teaches the election scheduler to consider both the previous and new balance when scheduling a block. With this change if an account sends its entire balance, the transaction will not be placed in the lowest priority bucket.